search

mlte-team / mlte

An infrastructure for evaluating machine learning models.
http://mlte.rtfd.io/
MIT License
9 stars 3 forks source link

Update Frontend to get Report data from new, unified model #459

Closed sebastian-echeverria closed 3 weeks ago

sebastian-echeverria commented 1 month ago

As per #458, the duplicated data in the Report model will be unified with the Negotiation Card to simplify the underlying code. Update the frontend to get the Report data from the new structure locations.

It would also be useful to add the data from the NegotiationCard model not currently in the report: that is, dev resources, and the list of QAS.

sei-aderr commented 3 weeks ago

Have updated the report model to use the new backend.

I don't think that the dev resources or QAS are intended to be added in the report even if the page has the data now, but would have to check with @GALewis to confirm that is the case.

GALewis commented 3 weeks ago

Thanks @sei-aderr. In one of the meetings that we had with Kate regarding the report, the idea is basically to replicate the date from the Negotiation Card in the report so that readers can have context. In that case, I believe the answer is yes.

sei-aderr commented 3 weeks ago

I am fine to add those fields to the report but, if we continue to add fields from the negotiation card to the report at some point we need to reconsider if they need to be separate entities when the report is all the same fields + 2 or 3 for results.

Similarly, the exported version of the report will need to be revisited if the report form continues to expand

GALewis commented 3 weeks ago

Understood. The thing with the Report is that it also has the test results; the rest is just context. But yes, I get your point.

sei-aderr commented 3 weeks ago

Going to close this task as complete with the frontend changes for the new unified model in task, adding the fields will be continued in report form evaluation in #463

sebastian-echeverria commented 3 weeks ago

Fixed by #448