mltframework / shotcut

cross-platform (Qt), open-source (GPLv3) video editor
https://www.shotcut.org
GNU General Public License v3.0
10.84k stars 1.12k forks source link

Zombie values in properties of "Time Remap" filter #1495

Closed rostbratwuerstchen closed 9 months ago

rostbratwuerstchen commented 9 months ago

Context

Tested with Shotcut Version 23.12.15

Steps To Reproduce

Expected Behavior

Playback speed should revert to constant speed (1.0x, initial value).

Actual Behavior

Despite the graph in keyframe view showing a linear time progression again, the filter behaves like the keyframe is still present. The value displayed under Speed is not constant over the length of the clip.

The issue persists when saving the project, restarting the application and loading the project.

Details

The UI updates the deprecated filter property map, while the filter internally uses the new property time_map. When a keyframe is set, the value of map is copied to time_map. When deleting the keyframe, this does not happen.

This is visible in the save file:

Before deleting the keyframe:

    <property name="map">0=0;5=8.436;354=14.16</property>
    <property name="time_map">00:00:00.000=0;00:00:00.200=8.436;00:00:14.160=14.16</property>

After deleting the keyframe:

    <property name="map">0=0;354=14.16</property>
    <property name="time_map">00:00:00.000=0;00:00:00.200=8.436;00:00:14.160=14.16</property>