Closed bmatherly closed 9 months ago
Nudging is tricky, partly because multiple in succession is expected. You can add a TimelineSelectionBlocker
inside each new action lambda to prevent clearing the selection, but the problem is that clipIndex
changes if a gap is opened or transition added. It generally works better with ripple on because if a gap opens to the left, the blank is selected, and nudging to the right works to somehow grow the blank and effectively continue to nudge the originally selected clip right, but not ripple-nudging a blank left. However, if multiple clips are selected other weirdness can occur. You should add that TimelineSelectionBlocker
and do more testing to see what I mean. I think the selection clearing or not sticking to the originally selected clip might be a blocker because otherwise it will cause a lot of bug reports or complaints.
Maybe some restrictions can be added such as:
For keyboard shortcuts, in the past I was thinking of using comma for backward and period for forward. At least on English keyboards these correspond to the < > keys (but those shortcuts are for marker seeking). But N is sensible too, I think.
I started implementing these rules in my working copy if you want to wait and evaluate.
I think those rules make sense. For me, personally, nudging is most important for a single selected clip. Maybe to keep it simple, nudging should only be enabled for a single selected clip. And nudging should NEVER cause a transition to be created. So it could fail out if there is not blank space following the clip. It might be easier to support to have simple limitations on the feature rather than trying to explain a complex combination of constraints to users.
OK, give these changes a try. Happy New Year
Thanks Dan. This works great for me. Happy new year to you as well!
A nudge moves the clip forward or backward one frame
Looking for some discussion on this idea. Dragging on the timeline does not work well in tiny increments. I know there are some workaround ways to move clips in small increments using snapping. But I do not find those to be intuitive.
I propose these two new nudge commands (forward and backward) that will move the selected clips by one frame. In this proof-of-concept, I added two commands to the hamburger and clip context menus.
I chose shortcuts "N" and "SHIFT+N" for forward and backward respectively.
One disadvantage to this is that when a move command occurs, the current selection is cleared. This makes it difficult to easily move a clip 3 frames (for example) by typing N+N+N - the user has to reselect the clip between each nudge. I think this might have been done to work around a problem with moving multiple clips across tracks. I am not sure. Maybe I can find a way to improve that.
Maybe users will request a way to specify how many frames should be in a nudge. If we can make quick repetition of nudges work, I do not think that would be worth the effort.