search

mltframework / shotcut

cross-platform (Qt), open-source (GPLv3) video editor
https://www.shotcut.org
GNU General Public License v3.0
10.84k stars 1.12k forks source link

Add configurable time format #1520

Closed bmatherly closed 6 months ago

bmatherly commented 7 months ago

This pull request is for review and staging until after the next release.

Add a new menu entry for time selection image

This entry affects everything except for the rulers in the player and timeline Here is a screenshot with some examples: image

Notes from the Design Discussion:

default to time clock format:

Not done - currently defaults to SMPTE DF - which was the previous display. I can change it, but I am concerned that some people will be surprised when they upgrade Shotcut and the time display changes.

context menu on the time display:

Not implemented. I made a Settings menu entry. I could also add a context menu on the time entry text field in the play if that is helpful. But people should be aware that it affects the entire application.

try to affect everywhere time is displayed:

Done - with the exception of the Rulers. I can also change the rulers. But I notice that there is some "fudge factor" logic that we would have to overcome. I think that is probably to get around rounding errors.

input parsing as well based on MLT’s interpretation of string to time:

Done

bmatherly commented 6 months ago

@ddennedy do you have a minute to review this? I would like to merge it. But I would like your comments since I deviated from the original design discussion somewhat.

ddennedy commented 6 months ago

No I’m traveling

ddennedy commented 6 months ago

Add a new menu entry for time selection

I prefer this over only the context menu. However, I think "Drop Frame" sounds too scary on its own and both drop and non-drop should end with "Timecode."

I can also change the rulers.

Well, the rulers are special as they use timecode without frames. I think it is good to leave them as-is.

currently defaults to SMPTE DF

I agree to not change the default. But mine defaulted to Non-Drop Frame.

bmatherly commented 6 months ago

However, I think "Drop Frame" sounds too scary on its own and both drop and non-drop should end with "Timecode."

Done. I put a different spin on it. Let me know what you think.

I agree to not change the default. But mine defaulted to Non-Drop Frame.

Fixed

image