mltframework / shotcut

cross-platform (Qt), open-source (GPLv3) video editor
https://www.shotcut.org
GNU General Public License v3.0
10.84k stars 1.12k forks source link

Add gps_power entry to GPS text filter #1567

Closed dany123 closed 1 month ago

dany123 commented 1 month ago

For https://github.com/mltframework/mlt/pull/1006

ddennedy commented 1 month ago

What about version check?

dany123 commented 1 month ago

The check is there at line 800 for the string composition. The switch case doesn't need a check because if the entry doesn't appear there won't be something to click to trigger case 21. I tested with a manually edited .yml and it works as intended for version 4 and 5

ddennedy commented 1 month ago

OK, I overlooked that. It is fine after MLT merge.