search

mltony / nvda-browser-nav

BrowserNav is NVDA add-on that enhances NVDA browse mode with new keystrokes.
GNU General Public License v2.0
14 stars 5 forks source link

modified the source in order for the messages to be included while generating the file for translating the addon #4

Closed Surveyor123 closed 2 years ago

Surveyor123 commented 2 years ago

I've opened a pool request for the same purpose months ago. Since it's outdated, I've modified the last repository.

mltony commented 2 years ago

Thanks for this PR. We probably shouldn't translate text of exceptions - so please remove localization in lines like: raise RuntimeError raise Exception Moreover, this looks like syntax error. Did you test these changes yourself? Other than that looks good - please make the correction and then I'll merge it.

Surveyor123 commented 2 years ago

Thanks for commenting. I've fixed and tested with no errors.