mltony / nvda-indent-nav

GNU General Public License v2.0
13 stars 5 forks source link

Possibility of using the traditional line manager for Java based applications #12

Open thgcode opened 1 year ago

thgcode commented 1 year ago

Currently, Java access bridge has a bug that crashes NVDA with this addon. If the text exceeds more than 10238 characters, writes from C++ code on the Java Access Bridge side may produce an access viollation and crash the NVDA process. I thought of an idea to overcome this limitation, currently the fast line manager gets all the lines from the text at once, however if a single text line don't exceed this number of characters, we could try to use the traditional line manager in this case to make the addon compatible with Java programs. However, since I don't know much about this addon's internals, I'm opening this for discussion. The best case would be to fix this on the Java Access Bridge side, however it would require both a Java and NVDA update. I was trying to use the addon to see the exception cause of a stack trace on IntelliJ Idea, for this case this fix could work.

mltony commented 1 year ago

I don't have much time these days to support addons.

So feel free to send PR if you can fix this. I am told that update_Cursor() method also doesn't work with IntelliJ, so it might be impossible to move the caret even once you compute the new position.

On 11/28/2022 5:00 PM, Thiago Seus wrote:

Currently, Java access bridge has a bug that crashes NVDA with this addon. If the text exceeds more than 10238 characters, writes from C++ code on the Java Access Bridge side may produce an access viollation and crash the NVDA process. I thought of an idea to overcome this limitation, currently the fast line manager gets all the lines from the text at once, however if a single text line don't exceed this number of characters, we could try to use the traditional line manager in this case to make the addon compatible with Java programs. However, since I don't know much about this addon's internals, I'm opening this for discussion. The best case would be to fix this on the Java Access Bridge side, however it would require both a Java and NVDA update. I was trying to use the addon to see the exception cause of a stack trace on IntelliJ Idea, for this case this fix could work.

— Reply to this email directly, view it on GitHub https://github.com/mltony/nvda-indent-nav/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJRDHAAUKE2A35DBPRFJKDWKVIUTANCNFSM6AAAAAASN5N5FQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>