search

mltony / nvda-word-nav

WordNav NVDA add-on improves built-in navigation by word, as well as adds extra word navigation commands with different definition fo the word.
GNU General Public License v2.0
8 stars 4 forks source link

Updated add-on template, Make add-ons compatible with NVDA-2023.1. #9

Closed cary-rowen closed 1 year ago

cary-rowen commented 1 year ago

Introduction

  1. Updated template for latest add-on.
    • Support Github Actions workflow.
    • To let the workflow run automatically when pushing to main or master (development) branch, remove the comment for branches line in GitHub Actions (.github/workflows/build_addon.yml).
    • Automatic generation of entries for NV Access add-on store (json format). Information specific to NV Access add-on store can be found here.
  2. Make the add-on compatible with NVDA-2023.1. For this add-on, just modify the buildVars.py file.

Additional Information

Let me know if you'd like me to enable the Github Action workflow in this PR. This way you only need to push a Tag after merging the PR to publish a new version of the add-on.

mltony commented 1 year ago

I see that you added some vscode project files - is this intentional? Typically we don't want these files, I don't even use vscode, unless I'm missing something?

On 4/1/2023 10:23 AM, Rowen wrote:

Introduction
  1. Updated template for latest add-on.
    • Support Github Actions workflow.
    • To let the workflow run automatically when pushing to main or master (development) branch, remove the comment for branches line in GitHub Actions (|.github/workflows/build_addon.yml|).
    • Automatic generation of entries for NV Access add-on store (json format). Information specific to NV Access add-on store can be found here https://github.com/nvaccess/addon-datastore.

  2. Make the add-on compatible with NVDA-2023.1. For this add-on, just modify the buildVars.py file.

    Additional Information

Let me know if you'd like me to enable the Github Action workflow in this PR. This way you only need to push a Tag after merging the PR to publish a new version of the add-on.

    You can view, comment on, or merge this pull request online at:

https://github.com/mltony/nvda-word-nav/pull/9

    Commit Summary

(9 files https://github.com/mltony/nvda-word-nav/pull/9/files)

— Reply to this email directly, view it on GitHub https://github.com/mltony/nvda-word-nav/pull/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJRDHG4JGQ3LDSRYN52OZLW7BQBFANCNFSM6AAAAAAWPYCLMY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

cary-rowen commented 1 year ago

As a supplement:

I see that you added some vscode project files - is this intentional? Hi tony, the vscode project file and flake8.ini are added by the new version of the add-on template, if you don't need these, I think I can delete them. Also, I bumped the add-on version to 1.9 please let me know if this is not required. Even if you want to release a new version all by yourself, that's fine, just close this PR, lol!