Closed salexan2001 closed 1 year ago
Hi - the example builds for me (and in CI) fine without these changes (and these changes cause the build to fail). Are you trying to build with a different version of rustyline?
Yes, that's true. I'm using rustyline version 12.0.0. Sorry, didn't check that.
Ah, I'm guessing you've tried to build it in a separate project. Feel free to bump the version in rlua along with the changes to make it work - I'm happy for it to be more up to date, which is bound to be more useful for anyone trying to use the example as a starting point (as I'm guessing is shown by this MR).
Tests look better with the bumped version, but unfortunately I have no idea what's wrong with the "build-lua..." tests.
Btw.: You are right, I'm trying to integrate it into a rust-based data analysis tool.
I think those failures will go away if you update your branch to the current master - I've recently disabled the bindgen checks as the output doesn't seem so stable recently (e.g. things end up in different orders on different machines).
Great, looks good, thanks - I just had one trivial comment before merging.
Excellent, thank you!
I tried to run the example
reple.rs
from the examples folder. Unfortunately it did not work, but yield the following error output:I was able to fix the problems and make the example work again.
Most of the changes displayed in git are whitespace changes due to formatting. In fact the patch is really short and boils down to: