search

mlua-rs / rlua

High level Lua bindings to Rust
Other
1.73k stars 115 forks source link

Add support for iOS to `rlua-lua54` #280

Closed w-ensink closed 1 year ago

w-ensink commented 1 year ago

Lua 5.4 supports iOS by defining a dummy system function, but rlua doesn't support building for iOS because of a missing preprocessor directive. This PR doesn't modify any original lua source code, it only adds a compiler flag based on the target platform.

Additionally, I fixed a warning for an unused return value :-)

Probably no need to update Cargo.toml to use a relative path after this version is released to crates.io...

jugglerchris commented 1 year ago

Looks good, thanks! Do you mind removing the Cargo.toml change before I merge it?

w-ensink commented 1 year ago

Do you mind removing the Cargo.toml change before I merge it?

Done ✅

jugglerchris commented 1 year ago

Thank you! Do you have any requirements on how quickly a release is made?

w-ensink commented 1 year ago

Do you have any requirements on how quickly a release is made?

Not really, I discovered this while looking to put a Lua interpreter on iOS, but I overlooked the lua-no-oslib feature doing that. I can get without this patch for now by using that feature. So no hurry!