mludlum / MarkdownPreview

MantisBT plugin to preview markdown markup below textarea boxes on report and update forms.
0 stars 0 forks source link

"error" popup when leaving site #9

Closed sagamusix closed 6 years ago

sagamusix commented 6 years ago

For example when pressing the submit button for an issue, you can briefly see an error message popping up. Since failures in this plugin are not critical to the system, I suggest logging them to the Console instead, or not logging them at all in a standard setup.

ajtruckle commented 6 years ago

This was discussed here and he mentions the code to comment out. This will stop the auto-preview though.

sagamusix commented 6 years ago

There is no need to remove all of it. Just the useless alert() needs to be commented out to get rid of the error message. There's no reason for it to be active in production code.

mludlum commented 6 years ago

sorry for the delay. I replaced the alert with console.log

sagamusix commented 6 years ago

Thanks!

ajtruckle commented 6 years ago

I replaced my file with the new one. Is it supposed to still auto refresh?

mludlum commented 6 years ago

auto refresh? I don't understand your question.

ajtruckle commented 6 years ago

The whole point of the timer was to update the preview as you type. With the preview showing below. Now we don't see a preview anymore unless we hit the preview button on the editor toolbar.

mludlum commented 6 years ago

Do you have a test site I can look at?

ajtruckle commented 6 years ago

Https://www.publictalksoftware.co.uk/mantisbt

Get Outlook for iOShttps://aka.ms/o0ukef


From: mludlum notifications@github.com Sent: Saturday, June 23, 2018 8:38:23 PM To: mludlum/MarkdownPreview Cc: ajtruckle; Comment Subject: Re: [mludlum/MarkdownPreview] "error" popup when leaving site (#9)

Do you have a test site I can look at?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmludlum%2FMarkdownPreview%2Fissues%2F9%23issuecomment-399703215&data=02%7C01%7C%7C0dcd2582111842bc797308d5d940e254%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636653795047636658&sdata=mfn3Qyc682GS6eDK3zjDQFaj9nKMrL3EH09FfB3mxRM%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHnYswPp0gVlQ2IsjUlpEm4UjI835gMlks5t_pkvgaJpZM4TP4wB&data=02%7C01%7C%7C0dcd2582111842bc797308d5d940e254%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636653795047636658&sdata=PIfbyl7AOaWQmYKDDU%2F9AnPDGSkiKblfmft0QWnihEE%3D&reserved=0.

mludlum commented 6 years ago

Using Chrome, right-click on your page, choose Inspect, and then look at the Console to see the real issue.
Your server or mantis is returning the wrong content-type for mpreview.php. I don't know why. I installed 2.15 and did not get the problem. You have 2.14. You could try installing the new version to see if that fixes it. In mpreview.php, I'm explicitly setting the content type. On my server, if I changed the content-type, it worked, so I know line 2 of mpreview.php is working .

ajtruckle commented 6 years ago

Sorted. I downloaded your complete module, unzipped and uploaded. All working. :)