mludowise / Sketch-Plugin-Manager

Keeping your Sketch plugins up to date.
https://mludowise.github.io/Sketch-Plugin-Manager/
Apache License 2.0
332 stars 15 forks source link

Chinese translation #25

Closed mludowise closed 7 years ago

mludowise commented 7 years ago

Based on app analytics, more than half of Sketch Plugin Manager's users primary language is Chinese (specifically zh-Hans-CN). I'd like help from someone fluent in Chinese to help translate to simplified and possibly also traditional Chinese.

I've posted instructions how to contribute: https://github.com/mludowise/Sketch-Plugin-Manager/tree/localize

mludowise commented 7 years ago

@cute @pluwen – You've both made contributions to the SketchI18N plugin, would you be interested in helping translate Sketch Plugin Manager?

pluwen commented 7 years ago

@mludowise I'm in!

pluwen commented 7 years ago

@mludowise Done. https://github.com/mludowise/Sketch-Plugin-Manager/pull/26

mludowise commented 7 years ago

Thank you! I'll integrate this into the plugin.

mludowise commented 7 years ago

I integrated the localization into the plugin. You should see the change if you update in Sketch Plugin Manager and your system has Chinese (Simplified) as one of the preferred languages.

Please let me know if you see any problems.

pluwen commented 7 years ago

Why not use UTF-8 ?

pluwen commented 7 years ago

Change some strings https://github.com/mludowise/Sketch-Plugin-Manager/pull/28

mludowise commented 7 years ago

Thank you. I'll include the fixes in the next update.

Regarding your comment on UTF-8, I believe the Localizable.strings file is already in UTF-8, is it not?

pluwen commented 7 years ago

no, it's UTF-16LE

mludowise commented 7 years ago

@pluwen Ah, yes. It looks like Apple wants the Localizable.strings files to be in UTF-16. When I import them into XCode, it automatically converts them from UTF-8 to UTF-16.

pluwen commented 7 years ago

ok