mludvig / smtp-cli

The ultimate command line SMTP client
http://smtp-cli.logix.cz
188 stars 32 forks source link

"Smartmatch is experimental" warning in perl 5.18 #3

Closed ghost closed 11 years ago

ghost commented 11 years ago

As of perl 5.18, the smartmatch_family_of_features_are_now_experimental.

As a result, running smtp-cli in perl 5.18 emits a warning:

Smartmatch is experimental at ... line 254

Per the docs:

Warnings will now be issued when the parser sees ~~, given, or when. To disable these warnings, you can add this line to the appropriate scope:

no if $] >= 5.018, "experimental::smartmatch";

Consider, though, replacing the use of these features, as they may change behavior again before becoming stable.

I would submit a pull request with the warning muted, but I think it's probably better not to paper over this =)

mludvig commented 11 years ago

Thanks for the report, I have rewritten the line for better compatibility with perl < 5.10 and perl >= 5.18.

Released as smtp-cli 3.6

Cheers

Michael

On 11/07/13 04:32, John Hart wrote:

As of perl 5.18, the smartmatch_family_of_features_are_now_experimental http://search.cpan.org/dist/perl-5.18.0/pod/perldelta.pod#The_smartmatch_family_of_features_are_now_experimental.

As a result, running smtp-cli in perl 5.18 emits a warning:

Smartmatch is experimental at ... line 254

Per the docs:

/Warnings will now be issued when the parser sees ~~, given, or when. To disable these warnings, you can add this line to the appropriate scope:/

no if $] >= 5.018, "experimental::smartmatch";

/Consider, though, replacing the use of these features, as they may change behavior again before becoming stable./

I would submit a pull request with the warning muted, but I think it's probably better not to paper over this =)

— Reply to this email directly or view it on GitHub https://github.com/mludvig/smtp-cli/issues/3.

ghost commented 11 years ago

Thanks for the fix - and more importantly, thanks for such a great tool.