mlukasek / M5_NightscoutMon

M5Stack Nightscout monitor
GNU General Public License v3.0
197 stars 153 forks source link

Migration to Platform.IO, split of README and CHANGELOG #35

Closed dlvoy closed 4 years ago

dlvoy commented 4 years ago

NightscoutMon is awesome project but has grown to the size that is no longer easily manageable by Arduino environment

In the series of events to re-organize, split into smaller parts (refactoring) and clean up of code i propose, by this PR:

mlukasek commented 4 years ago

I am afraid of change the main project to VSCode & PlatformIO. Most of the people are not experienced with computers and Arduino is easier to setup and use. I updated the sources that in can be compiled with PlatformIO just by renaming .ino to .cpp and added PlatformIO folder for anyone who would like to use it. Maybe some time later, we can switch it over, but I am afraid do it now. I also split and updated the README adn CHANGELOG as you suggested.

dlvoy commented 4 years ago

I understand that concerns, but i would argue. There are probably two categories of users:

Arduino IDE is nice to teach kids about blinking LEDs, but anything bigger is, in fact, harder - due to lack of support for even most basic tools. Currently monitor has 3000+ lines of code, so it is no small project by any means ;)

I working on refactoring code - will push changes in near future - i hope i will get you convinced about it ;) Maybe video or screenshot guide for developers/hackers will clarify how easy it is to use it with VSCode. Anyway - thanks for accepting this PR and awesome work you do on this project!

mlukasek commented 4 years ago

Hi Dominik,

I will not definitely change it soon. I agree with you, that it is faster and more comfortable, but I have a lot of experience with user support and it is sometimes pretty difficult. It is not as clear as average user vs. hacker, there are many varieties of users. Another reason is that I will not be able to do any support for more than 3 weeks from now, so I do not want to make any big changes. I have no longtime tests with binary built by PlatformIO. I will let it run for some time and then I will see.

If you plan to do any changes to the code, that you want to make to my master, then please keep CRLF. Thanks.

Best regards

Martin