Update root CA used for herokuapp.com and re-enable TLS

mlukasek / M5_NightscoutMon

M5Stack Nightscout monitor

GNU General Public License v3.0

197 stars 153 forks source link

Update root CA used for herokuapp.com and re-enable TLS #64

Closed 15characterlimi closed 3 years ago

15characterlimi commented 3 years ago

https://github.com/mlukasek/M5_NightscoutMon/commit/34c5217f28193e7cbad2933391feb7571f79c3a7 disabled https connection as a temporary workaround for TLS connections no longer working after https://devcenter.heroku.com/changelog-items/2152

This pull request updates the root CA (still hard coded in PEM form) and re-enables https.

mlukasek commented 3 years ago

Thaks, I merged the pull request, but I will have to investigate it further. It stil uses SSL, even without the hardcoded certficiated. I just found that it behaves better with the hardcocded certificate, so I implemented it for Heroku. I am not sure if this is good way, as they could revoke it again any time. The last one was supposed to work till 2031 :-(