search

mlutfy / reporterror

Sends you a detailed email when a CiviCRM fatal error occurs.
https://lab.civicrm.org/extensions/reporterror
10 stars 7 forks source link

Uninstall doesn't work on 4.7.11 #21

Closed michaelmcandrew closed 7 years ago

michaelmcandrew commented 8 years ago

Hey there,

I'm not sure when the group_name was removed from the civicrm_setting file but it is causing the uninstall to fail (https://github.com/mlutfy/ca.bidon.reporterror/blob/master/reporterror.php#L61)

I had a look for a delete method in CRM_Core_BAO_Setting and in the Setting api but coudn't find one. Which I presume is the reason you didn't use it :)

But it seems like you have a valid reason for deleting settings, so...

mlutfy commented 8 years ago

That code was written back in the 4.2 days, so yep, it should probably be updated. :-) Thanks for reporting the issue!

michaelmcandrew commented 8 years ago

np :)

mlutfy commented 7 years ago

This should be fixed. It's not a great fix, but it works :)