search

mlverse / torchaudio

R interface to torchaudio
https://mlverse.github.io/torchaudio/
Other
27 stars 6 forks source link

install OS libs before R pkgs #48

Closed skeydan closed 1 year ago

skeydan commented 1 year ago

OK, this seems to have worked, but there are lots of test errors (basically the same on all OSes).

Did those use to work? See e.g. https://github.com/curso-r/torchaudio/actions/runs/3756345668/jobs/6382317617

Should we fix them before submitting to CRAN (where tests don't run)?

dfalbel commented 1 year ago

I think it's important to at least understand why they are failing and remove them if we end up concluding they are not necessary. They might be hiding failures in other parts of the package code.

skeydan commented 1 year ago

Makes sense! Will create a separate issue for that, so this can be about the workflow only.

skeydan commented 1 year ago

I guess this one could be merged, then? (So PR checks won't fail with this)