search

mlysy / pfjax

Particle filtering in JAX
https://pfjax.readthedocs.io
MIT License
1 stars 0 forks source link

Dev mohan #5

Closed mlysy closed 2 years ago

mlysy commented 2 years ago

Hi @mohanwu, can you please make the requested changes, and also fix the merge conflicts below? (I think only the lotvol.ipynb is needed, see comment about particle_filter.py above.)

mohanwu commented 2 years ago

I updated the necessary files from the comments and the todo.ipynb. I also noticed that tests/lotvol_model.py is not needed anymore (in a similar way to pgnet_model.py) so I deleted that. Then in order to uses src/pfjax/pgnet_model.py, I updated tests/utils.py to import from there. This also applies to lotvol_model.py. All tests have passed on my end.