search

mm-adt / vm

The mm-ADT Virtual Machine
http://vm.mm-adt.org
GNU Affero General Public License v3.0
34 stars 5 forks source link

Changed asciidoctorj and asciidoctorj-diagram to latest working versions. #7

Closed bshambaugh closed 4 years ago

bshambaugh commented 4 years ago

The program was unable to build, so I looked in the maven repository for the latest versions of asciidoctorj* .

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

bshambaugh commented 4 years ago

I was able to launch the jvm/bin/mmadt.sh , but if there is something that this broke, I do not know it yet.

okram commented 4 years ago

Downgrading to older versions seems an awkward solution to the problem. Moreover, the versions of asciidoctorj main and diagrams are no longer synchronized. Have you built the docs to see if this causes problems with doc rendering?

okram commented 4 years ago

I just upgraded to the latest version of asciidoctorj (2.4.0 -- released a few hours ago). I removed the asciidoctorj-diagram dependency and built the docs. they render as expected. seems 2.4.0 includes diagramming in it.

bshambaugh commented 4 years ago

This is better. I didn't see 2.4.0. Moreover, I realized that I didn't build the docs. Like hitting the blinking red button to get jvm to work. Thanks. Agreed. What you went ahead with was optimal.

for the record, slack rant. "Hmm... I was using 3.2.0 for asciidoctorj . 2.4.0 was the latest version of asciidoctorj-diagram. I realized last night I didn't test the build with asciidoctor... just the jvm. changing the build.sbt script got the computer to stop complaining. (edited) 4:37 realizing this, I'm looking at how the asciidoctor build part works 4:38 tl;dr...3.2.0 is in the maven repo. investigating. 4:40 oh nvm...I can't count....looking at https://repo1.maven.org/maven2/org/asciidoctor/asciidoctorj/2.4.0/"