2.16: meson falis

[kloczek]

Looks like something is wrong with just released 2.16

+ /usr/bin/meson setup --buildtype=plain --prefix=/usr --libdir=/usr/lib64 --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin --includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man --infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc --localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload --auto-features=enabled . x86_64-redhat-linux-gnu -D jpeg=enabled -D samples=true -D threaded=true -D tiff=enabled
The Meson build system
Version: 1.3.0
Source dir: /home/tkloczko/rpmbuild/BUILD/Little-CMS-lcms2.16
Build dir: /home/tkloczko/rpmbuild/BUILD/Little-CMS-lcms2.16/x86_64-redhat-linux-gnu
Build type: native build
Project name: Little-CMS
Project version: 2.16
C compiler for the host machine: /usr/bin/gcc (gcc 13.2.1 "gcc (GCC) 13.2.1 20231110 (Red Hat 13.2.1-5)")
C linker for the host machine: /usr/bin/gcc ld.bfd 2.41-15
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C supports function attribute visibility:hidden: YES
Header "time.h" has symbol "gmtime_r" : YES
Found pkg-config: YES (/usr/bin/pkg-config) 2.0.3
Run-time dependency libjpeg found: YES 3.0.1
Run-time dependency libtiff-4 found: YES 4.6.0
Checking if "supports SSE2 intrinsics" compiles: YES
Library m found: YES
Run-time dependency threads found: YES
Checking for function "pthread_mutex_lock" with dependency threads: YES
Header "time.h" has symbol "timespec_get" : YES

utils/samples/meson.build:8:31: ERROR: Unknown variable "common_dep".

[mm2]

Hi thanks for reporting. Too bad this is not the candidate but the final release, so the fix will have to wait to the next train. As a workaround, please don't include the samples, which are not needed in any case, just remove "-D samples=true" in your command line. That should not be here, samples are only for reference, not to be compiled. Whole option will be removed asap.

[kloczek]

According to packaging rules which I'm following building sample programs of libraries even if they are not installed/used on testing is obligatory .. only because it is yet another opportunity to check API of the packages library 😋

[mm2]

Sure, but those were never intended to be compiled. Some does even not compile at all. The autotools script didn't install that. I got a PR contribution with meson build and didn't realize they included such samples. Please avoid that, I am going to remove those old samples from the meson build soon. BTW, the package includes another set of fully supported samples and a unit test that compiles fine. Those that does not work are snippets of code from older versions as lcms1. Thanks again for pointing out the issue.

[kloczek]

Nevertheless with prev version it was OK 😋

[mm2]

Samples are no longer compiled by meson, so the issue is gone.

[kloczek]

Samples are no longer compiled by meson, so the issue is gone.

Is it possible to release new version because of bc3fc00a? 🤔