search

mm201 / pkmn-classic-framework

Pokémon application logic for Generation IV and V, including servers
http://pkmnclassic.net/
Other
219 stars 43 forks source link

Pokemon Platinum Wii Message Board Support #101

Closed zurgeg closed 2 years ago

zurgeg commented 2 years ago

Before I say anything else, this probably won't happen unless we could somehow let it work with RC24 or an email (but email only works on JP copies)

With that said, Pokemon Platinum had a feature where you could get notifications whenever a GTS trade for the Pokemon you put up finished. Currently, I don't think pkmn-classic supports this. I can't find anything in the code relating to it, so it probably doesn't.

This actually could come in handy for those that don't check GTS often.

EDIT: It actually does appear that pkmn-classic has stubs for this (similar to how GS is implemented currently), but it would be nice to somewhat "bump" this implementation. I might make a PR to make it work later

zurgeg commented 2 years ago

Oop, this is apparently a dupe of #34

mm201 commented 2 years ago

I actually have the server API fully implemented, and interfacing with Riiconnect is very easy: just replace the @wii.com with @rc24.xyz and send.

What remains to be done is to create the email notification background service itself. It's no small task and I've been working on other things for the moment.

I deliberately have it send response 0x02 ("There was an error while attempting to send an authentication Wii message") to avoid getting the user stuck on a screen asking for a confirmation code I can't yet send, and because it's the truth.

zurgeg commented 2 years ago

I actually have the server API fully implemented, and interfacing with Riiconnect is very easy: just replace the @wii.com with @rc24.xyz and send.

What remains to be done is to create the email notification background service itself. It's no small task and I've been working on other things for the moment.

I deliberately have it send response 0x02 ("There was an error while attempting to send an authentication Wii message") to avoid getting the user stuck on a screen asking for a confirmation code I can't yet send, and because it's the truth.

Ah. IMO the best way to do something like that is not with a background task, but by actually doing it within the route itself, but I'm not that much of an expert on ASP.NET coding practices, so it might not be a good idea to do something like that.