search

mm90849491 / CoopR-S

pronounce: C R and S
0 stars 5 forks source link

[Priority: high] refine UI #43

Open mm90849491 opened 8 years ago

mm90849491 commented 8 years ago

The following pages' UI needs to be refined: post/edit, setting, compare, verify_mailer/send_mail.text.erb

The following pages' UI needs to be updated accordingly: post/show, +(verify_mailer/send_maill.html.erb), lyaouts/.

AmberQi1412 commented 8 years ago

Should I do something other than rake db:migrate to the database, so that I can know the accurate views of posts/show or setting/display?

I merged master to my current branch, and the fields_for @job appears on every posts/new page no matter what the user type is.

Please tell me if I need to update the database, so I can have a clearer picture on updating UI. Thanks.

----- Original Message ----- From: "Meng Meng" notifications@github.com To: "mm90849491/CoopR-S" CoopR-S@noreply.github.com Sent: Wednesday, 27 July, 2016 04:11:30 Subject: [mm90849491/CoopR-S] [Priority: high] refine UI (#43)

The following pages' UI needs to be refined: post/edit, setting, compare, verify_mailer/send_mail.text.erb

The following pages' UI needs to be updated accordingly: post/show, +(verify_mailer/send_maill.html.erb), lyaouts/.

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/mm90849491/CoopR-S/issues/43

mm90849491 commented 8 years ago

Remember we are doing job review/promotion. I think it makes sense both Student and Company user should have a job in the post. As you can test, company's post does not have a company id field on @job form. That is the only difference. You might make the layout of those two type of post looks really different but it is more important to finalise as many pages as you can. I will make the announcement type of post, which you might see in the index controller and it does nothing right now, after all important features are implemented. Hence, you can assume that is the almost-final-looking of the post. I keep forgetting to add job requirement (min-gpa, full time/part time, year of university, program ......). I would not touch the job/profile tables until authentication feature is done. You can add those fields first and I will adjust the database accordingly. Just remember to allow more columns and rows in your design.

On 28 July 2016 at 15:36, AmberQi1412 notifications@github.com wrote:

Should I do something other than rake db:migrate to the database, so that I can know the accurate views of posts/show or setting/display?

I merged master to my current branch, and the fields_for @job appears on every posts/new page no matter what the user type is.

Please tell me if I need to update the database, so I can have a clearer picture on updating UI. Thanks.

----- Original Message ----- From: "Meng Meng" notifications@github.com To: "mm90849491/CoopR-S" CoopR-S@noreply.github.com Sent: Wednesday, 27 July, 2016 04:11:30 Subject: [mm90849491/CoopR-S] [Priority: high] refine UI (#43)

The following pages' UI needs to be refined: post/edit, setting, compare, verify_mailer/send_mail.text.erb

The following pages' UI needs to be updated accordingly: post/show, +(verify_mailer/send_maill.html.erb), lyaouts/.

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/mm90849491/CoopR-S/issues/43

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mm90849491/CoopR-S/issues/43#issuecomment-235811508, or mute the thread https://github.com/notifications/unsubscribe-auth/AKPDV61ybvYjkcVmvwqBymoQgqkXLFujks5qaE32gaJpZM4JWFRw .

mm90849491 commented 8 years ago

Forgot to mention, it is normal that some user (almost all user except admin) do not have profile table on setting page. Only user who created a profile would see that table, I will either add a button on setting page somewhere to initialise a profile later, or make Company and authenticated Student having a profile by default. Normal Student shall not have a profile, to save database space.