search

mm90849491 / CoopR-S

pronounce: C R and S
0 stars 5 forks source link

Most pages done. #66

Open AmberQi1412 opened 8 years ago

AmberQi1412 commented 8 years ago

All UI part works fine, just try it, I meant to make the pages look nicer. And for the sidebar, it can be considered user-friendly because users may want to hide navbar and concentrate on the contents when viewing pages.

mm90849491 commented 8 years ago

how about mobile device, like touch screen? at least make it on the right side which is closer to the menu button

On 2 August 2016 at 17:39, AmberQi1412 notifications@github.com wrote:

All UI part works fine, just try it, I meant to make the pages look nicer. And for the sidebar, it can be considered user-friendly because users may

want to hide navbar and concentrate on the contents when viewing pages.

You can view, comment on, or merge this pull request online at:

https://github.com/mm90849491/CoopR-S/pull/66 Commit Summary

  • fix fix fix
  • post pages ongoing
  • post/show
  • adjust shadow
  • profile-page structure set, elements contained to be adjust
  • profile page almost done
  • profile page finished

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mm90849491/CoopR-S/pull/66, or mute the thread https://github.com/notifications/unsubscribe-auth/AKPDV2lmSs0twGpdqDczmsWhHvEMjh3_ks5qbwImgaJpZM4JaXsx .

mm90849491 commented 8 years ago

There are lots of conflicts in this push and I need to try to merge Ivan's pull request. Can you figure out which pages you need to rework based on current master branch?

AmberQi1412 commented 8 years ago

I'll merge master to my branch, it should not be hart

----- Original Message ----- From: "Meng Meng" notifications@github.com To: "mm90849491/CoopR-S" CoopR-S@noreply.github.com Cc: "AmberQi1412" qingyunq@sfu.ca, "Author" author@noreply.github.com Sent: Tuesday, 2 August, 2016 03:28:34 Subject: Re: [mm90849491/CoopR-S] Most pages done. (#66)

There are lots of conflicts in this push and I need to try to merge Ivan's pull request. Can you figure out which pages you need to rework based on current master branch?

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mm90849491/CoopR-S/pull/66#issuecomment-236865831

mm90849491 commented 8 years ago

is this branch finished or not?

AmberQi1412 commented 8 years ago

I'll merge the latest updates to it. If U want to merge to master, the signup page has a little problem, other than that, the UI should be OK. I'm working on it now

----- Original Message ----- From: "Meng Meng" notifications@github.com To: "mm90849491/CoopR-S" CoopR-S@noreply.github.com Cc: "AmberQi1412" qingyunq@sfu.ca, "Author" author@noreply.github.com Sent: Tuesday, 2 August, 2016 13:05:33 Subject: Re: [mm90849491/CoopR-S] Most pages done. (#66)

is this branch finished or not?

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mm90849491/CoopR-S/pull/66#issuecomment-237026762

mm90849491 commented 8 years ago

-there are lots of problem with the index page, e.g. menu no longer accessible on small screen -show page of post lost the suggestion function, job information and double notice problem, and the layout corrupts after resize -actually the notice div stays where it was which is annoying -create post page seems fin but again resize will break it easily, just do not leave any margin to left or right, it's wasting space

There is no time to fix those problems, you can keep working after the presentation, but I will use the current version for presentation. I really like the create post style, can you just work on extract the css file and html code for the new post page so we might finish it before the presentation?

On 3 August 2016 at 05:55, AmberQi1412 notifications@github.com wrote:

I'll merge the latest updates to it. If U want to merge to master, the signup page has a little problem, other than that, the UI should be OK. I'm working on it now

----- Original Message ----- From: "Meng Meng" notifications@github.com To: "mm90849491/CoopR-S" CoopR-S@noreply.github.com Cc: "AmberQi1412" qingyunq@sfu.ca, "Author" author@noreply.github.com Sent: Tuesday, 2 August, 2016 13:05:33 Subject: Re: [mm90849491/CoopR-S] Most pages done. (#66)

is this branch finished or not?

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mm90849491/CoopR-S/pull/66#issuecomment-237026762

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mm90849491/CoopR-S/pull/66#issuecomment-237040772, or mute the thread https://github.com/notifications/unsubscribe-auth/AKPDV3pQma4mG8lwUWW4CbHv21OJmeEsks5qb67SgaJpZM4JaXsx .

AmberQi1412 commented 8 years ago

OK, I'll work on the new post page.

----- Original Message ----- From: "Meng Meng" notifications@github.com To: "mm90849491/CoopR-S" CoopR-S@noreply.github.com Cc: "AmberQi1412" qingyunq@sfu.ca, "Author" author@noreply.github.com Sent: Tuesday, 2 August, 2016 14:49:52 Subject: Re: [mm90849491/CoopR-S] Most pages done. (#66)

-there are lots of problem with the index page, e.g. menu no longer accessible on small screen -show page of post lost the suggestion function, job information and double notice problem, and the layout corrupts after resize -actually the notice div stays where it was which is annoying -create post page seems fin but again resize will break it easily, just do not leave any margin to left or right, it's wasting space

There is no time to fix those problems, you can keep working after the presentation, but I will use the current version for presentation. I really like the create post style, can you just work on extract the css file and html code for the new post page so we might finish it before the presentation?

On 3 August 2016 at 05:55, AmberQi1412 notifications@github.com wrote:

I'll merge the latest updates to it. If U want to merge to master, the signup page has a little problem, other than that, the UI should be OK. I'm working on it now

----- Original Message ----- From: "Meng Meng" notifications@github.com To: "mm90849491/CoopR-S" CoopR-S@noreply.github.com Cc: "AmberQi1412" qingyunq@sfu.ca, "Author" author@noreply.github.com Sent: Tuesday, 2 August, 2016 13:05:33 Subject: Re: [mm90849491/CoopR-S] Most pages done. (#66)

is this branch finished or not?

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mm90849491/CoopR-S/pull/66#issuecomment-237026762

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mm90849491/CoopR-S/pull/66#issuecomment-237040772, or mute the thread https://github.com/notifications/unsubscribe-auth/AKPDV3pQma4mG8lwUWW4CbHv21OJmeEsks5qb67SgaJpZM4JaXsx .

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mm90849491/CoopR-S/pull/66#issuecomment-237056429