search

mmaelicke / scikit-gstat

Geostatistical variogram estimation expansion in the scipy style
https://mmaelicke.github.io/scikit-gstat/
MIT License
227 stars 55 forks source link

RasterEquidistantMetricSpace errors with scipy 1.0 #186

Open mmaelicke opened 5 months ago

mmaelicke commented 5 months ago

This line is not supported anymore with scipy 1.0:

https://github.com/mmaelicke/scikit-gstat/blob/22ff51ce798e0bfb4280392b32cbf9d9a480d89a/skgstat/MetricSpace.py#L786

see also https://github.com/scipy/scipy/issues/8338

With #185 the bug is fixed for now, as the old, slower code is used again. If we want to change the dok matrix directly we need to do that via fancy indexing. @rhugonnet if I remember correctly, you implemented this class, right? Can you comment on this?

I just commented out the non-working solution, so to close this issue we could either remove the commented code, or implement a better solution.

rhugonnet commented 3 months ago

@mmaelicke Just back from holidays, I'll have a look very soon!

rhugonnet commented 2 months ago

Hi @mmaelicke, I looked at this again this afternoon. I could not find a solution to keep the old (fast) method post-SciPy 1.13. The classic update() still does not work. It's good that we have the other solution at least.

I will have to dive into this more when I address the other points I mentioned in #178 to revamp that metric space and document it! It'll probably end in opening a SciPy issue to ask about that functionality.

I think we can close this issue, and I will rename #178 towards documenting the RasterMetricSpace!