search

mmajcica / DeploySsrs

Build-Release task for VSTS/TFS that manages Microsoft's SQL Server Reporting Services
MIT License
21 stars 21 forks source link

Issues involving loading configuration via Json #25

Closed ExcaliburVT closed 5 years ago

ExcaliburVT commented 5 years ago

[Folder]:new() doesn't have a 3 parameter overload, assume it was refactored and not tested with the JSON Version

Two calls to the += operator were not valid and did not appear to be needed.

Converted the true/false to boolean just like the GetXmlFolderItems method.

Added a Json version of the example ReportConfiguration file

mmajcica commented 5 years ago

First of all, thanks. You are right assuming that the JSON config was not much tested. Initially, the configuration should have only be supplied via the JSON config file, however, during the development on the customers site I realized that XML is going to be the format, so I decided to implement the necessary and I tested thoroughly only XML config files. I did a quick review of the changes you made, if you do agree with my comments, I'll merge and deploy a new version today.

ExcaliburVT commented 5 years ago

Very big thank you to YOU for all this work, it made the SSRS deployment so much easier! Agree with your comments and those changes should now be applied.

mmajcica commented 5 years ago

In the README.md hidden fields are still specified as string. I'll fix this before publishing a new version.