Display in zcharts the machine it is being tested on

[lognorman20]

Closes #14

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zkalc	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2023 5:46am

[mmaker]

omg thank you! this looks mostly ok -- just a few tiny changes for me to accept it.

[lognorman20]

Okay, anything in particular you want me to change?

[mmaker]

Check the code review!

On Tue 5 Sep 2023 at 22:18, Logan Norman @.***> wrote:

Okay, anything in particular you want me to change?

— Reply to this email directly, view it on GitHub https://github.com/mmaker/zkalc/pull/35#issuecomment-1707255695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACD7BJ5AN4QCPAREANF4LTXY6CKDANCNFSM6AAAAAA4KWBHWI . You are receiving this because you commented.Message ID: @.***>

[lognorman20]

Okay, how do I see the code review? I know about this page but don't see any comments

[mmaker]

my bad, I didn't submit them!

[lognorman20]

Got it, thanks

On Tue, Sep 5, 2023 at 1:27 PM Michele Orrù @.***> wrote:

@.**** commented on this pull request.

On frontend/package-lock.json https://github.com/mmaker/zkalc/pull/35#discussion_r1315228668:

can you please remove this file from the patch? Or is it strictly necessary? I'll run the update once merged.

In frontend/app/charts/page.js https://github.com/mmaker/zkalc/pull/35#discussion_r1315548684:

• menu={{
• items: machines_selection[curve][lib].reduce(function (res, selectedMachine) {
• if (!selectedMachine.disabled) {
• res.push({
• label: selectedMachine.label,
• onClick: () => _setMachine(selectedMachine.key),
• })
• }
• return res;
• }, [])
• }}
• <a onClick={(e) => e.preventDefault()}>
• {machines[machine].label}

hmm weird. This is rendered as: [image: Screenshot 2023-09-05 at 10 20 04] https://user-images.githubusercontent.com/278405/265633459-c8550d08-fbb6-407c-ba10-24dd951fc32f.png

which feels like has too much space on the left and too little on the right -- can you adjust it so that it feels more natural?

— Reply to this email directly, view it on GitHub https://github.com/mmaker/zkalc/pull/35#pullrequestreview-1609993689, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQJOD45WXCXA3YSTHX344O3XY6DJRANCNFSM6AAAAAA4KWBHWI . You are receiving this because you authored the thread.Message ID: @.***>

[mmaker]

Great thanks!