mmalinowski42 / dynatree

Automatically exported from code.google.com/p/dynatree
0 stars 0 forks source link

DnD: position of drop-marker is the same for before, after and over #439

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
jquery-ui no longer support 

.position({
   offset: 
});

http://jqueryui.com/upgrade-guide/1.9/#deprecated-offset-option-merged-into-my-a
nd-at

patch: line 2630 - 2667

            var markerOffsetLeft = "";
            var markerOffsetTop = "";

            switch(hitMode){
            case "before":
                this.$dndMarker.removeClass("dynatree-drop-after dynatree-drop-over");
                this.$dndMarker.addClass("dynatree-drop-before");
                markerOffsetTop = "-8";
                break;
            case "after":
                this.$dndMarker.removeClass("dynatree-drop-before dynatree-drop-over");
                this.$dndMarker.addClass("dynatree-drop-after");
                markerOffsetTop = "+8";
                break;
            default:
                this.$dndMarker.removeClass("dynatree-drop-after dynatree-drop-before");
                this.$dndMarker.addClass("dynatree-drop-over");
                $target.addClass("dynatree-drop-target");
                markerOffsetLeft = "+8";
            }
//          logMsg("Creating marker: %o", this.$dndMarker);
//          logMsg("    $target.offset=%o", $target);
//          logMsg("    pos/$target.offset=%o", pos);
//          logMsg("    $target.position=%o", $target.position());
//          logMsg("    $target.offsetParent=%o, ot:%o", $target.offsetParent(), 
$target.offsetParent().offset());
//          logMsg("    $(this.divTree).offset=%o", $(this.divTree).offset());
//          logMsg("    $(this.divTree).parent=%o", $(this.divTree).parent());
//          var pos = $target.offset();
//          var parentPos = $target.offsetParent().offset();
//          var bodyPos = $target.offsetParent().offset();

            this.$dndMarker
                .show()
                .position({
                    my: "left" + markerOffsetLeft + " top" + markerOffsetTop,
                    at: "left top",
                    of: $target,
                });

Original issue reported on code.google.com by mwikb...@gmail.com on 28 Jun 2013 at 7:31

GoogleCodeExporter commented 9 years ago

Original comment by moo...@wwwendt.de on 28 Jun 2013 at 3:14

GoogleCodeExporter commented 9 years ago
Cleanup Scrumboard

Original comment by moo...@wwwendt.de on 2 May 2014 at 7:47