mmanela / chutzpah

Chutzpah is an open source JavaScript test runner which enables you to run unit tests using QUnit, Jasmine, Mocha and TypeScript.
http://mmanela.github.io/chutzpah/
Apache License 2.0
550 stars 142 forks source link

Waiting until Internet Explorer process being debugged has exited before continuing when using the web server #802

Closed icnocop closed 3 years ago

icnocop commented 3 years ago

Added IEBrowserTabOpenTimeout setting Fixed typos Waiting until Internet Explorer process being debugged has exited before continuing when using the web server Using Microsoft.VisualStudio.Shell.14 nuget package Using Microsoft.VSSDK.BuildTools.15.0.26201 released nuget package Fixes #787

mmanela commented 3 years ago

This is a great PR. Some questions/comments

  1. Wow, thanks for the typo fixes. That is quite embarrassing ;)
  2. What versions of VS did you test this on? (Do you know if the upgrades / additions on the nuget packages will affect version compatibility?)
icnocop commented 3 years ago

Thank you for the code review.

1. Wow, thanks for the typo fixes. That is quite embarrassing ;)

No worries. :)

2. What versions of VS did you test this on?  (Do you know if the upgrades / additions on the nuget packages will affect version compatibility?)

I built the code using Visual Studio 2017 and tested on Visual Studio 2019.

I don't think the upgrades should affect version compatibility because I kept the same major version.

Can the sample projects be open in older versions of Visual Studio and be used to test backwards compatibility?

icnocop commented 3 years ago

Here is Chutzpah.VS2012.vsix built from this pull request, installing on another machine with Visual Studio 2015, 2017, and 2019 installed:

image

image

icnocop commented 3 years ago

Here is the Test Explorer window in Visual Studio 2015:

image

image

icnocop commented 3 years ago

Let me know if you'd like me to squash my commits into one.

mmanela commented 3 years ago

Its fine, sorry for the delay. I didn't have a window environment setup, just got a VM built and will take a look.

mmanela commented 3 years ago

Ok works! Thanks for the great PR