mmangino
commented
12 years ago I just pulled this in. Also, you were right about the tests, I hadn't pulled on this computer in a while. I just fixed them.
Thanks!
On Nov 7, 2011, at 5:54 AM, Florent Vaucelle wrote:
Hi, small fix to prevent an error to raise.
Had an error when the Facebook cookie key was present, but the value was a blank String. Consequence of my commit is no more error, and user not authenticated, which seems kind of logical. Only drawback would be that when a user is unable to login to your app and report and issue, this [blank cookie value] issue would be more difficult to track.
Florent
You can merge this Pull Request by running:
git pull https://github.com/florent/facebooker2 master
Or you can view, comment on it, or merge it online at:
https://github.com/mmangino/facebooker2/pull/66
-- Commit Summary --
- fb_cookie? returns false if the Facebook cookie has a blank value
-- File Changes --
M Gemfile (4) M lib/facebooker2/rails/controller.rb (2) M spec/rails/controller_spec.rb (14)
-- Patch Links --
https://github.com/mmangino/facebooker2/pull/66.patch https://github.com/mmangino/facebooker2/pull/66.diff
Reply to this email directly or view it on GitHub: https://github.com/mmangino/facebooker2/pull/66
Mike Mangino http://www.elevatedrails.com
florent
Hi, small fix to prevent an error to raise.
Had an error when the Facebook cookie key was present, but the value was a blank String. Consequence of my commit is no more error, and user not authenticated, which seems kind of logical. Only drawback would be that when a user is unable to login to your app and report and issue, this [blank cookie value] issue would be more difficult to track.
Florent