search

mmaraya / port-mirroring

OpenWrt package for copying network packets without iptables
BSD 2-Clause "Simplified" License
103 stars 32 forks source link

CID 19975: Missing return statement #22

Closed mmaraya closed 9 years ago

mmaraya commented 9 years ago

https://github.com/mmaraya/port-mirroring/blob/24338719d79f368f9dfc6b036d627ea4bbaf8903/port-mirroring.c#L958

CID 19975 (#4 of 4): Missing return statement (MISSING_RETURN)
missing_return: Arriving at the end of a function without returning a value.

The return value will be taken from whatever happens to be on the stack, likely causing incorrect computation. In start_mirroring: Function that returns non-void is missing a return value (CWE-710)