search

mmarch / rds-templates

ARM templates for RDS deployments
1 stars 0 forks source link

Case sensitive parameters in azuredeploy.parameters.json in RDS HA-Gateway template #14

Closed fberson closed 7 years ago

fberson commented 7 years ago

It seems like ARM is Case Sensitive and does not like the fact that the parameter.json file contains

       "BrokerServer": {
        "value": "broker.rdsgurus.com"
},

And the deployment.json contains

       "brokerServer": {
         "type": "string",
        "metadata": {
         "description": "FQDN for Broker Server"
         }
},

I would suggest to change the parameter in deployment.json to match the one in parameter.json

mmarch commented 7 years ago

best practices require parameters follow Camel case notation, so we should be using names starting with lowercase (azuredeploy.parameters.json parameters should match azuredeploy.json, and not vice versa)

mmarch commented 7 years ago

PR #3304

mmarch commented 7 years ago

PR #3304 merged to Azure:master on 3/07/2017. Closing...