search

mmark-md / mmark

Strict markdown processor for writers
Other
111 stars 20 forks source link

Test failures when building with `modern-uri-0.3.4.3` #85

Closed hololeap closed 2 years ago

hololeap commented 2 years ago

I'm building mmark on Gentoo Linux using ghc-9.0.2, and I found that certain tests fail with the latest version bump to modern-uri-0.3.4.3. These tests are passing when I build with modern-uri-0.3.4.2:

Failures:

  tests/Text/MMark/TestUtils.hs:111:37: 
  1) parse and render, 6.2 Entity and numeric character references, CM309
       expected: "<p><a href=\"/f&amp;ouml;&amp;ouml;\" title=\"föö\">foo</a></p>
"
        but got: "<p><a href=\"/f%26ouml%3b%26ouml%3b\" title=\"föö\">foo</a></p>
"

  To rerun use: --match "/parse and render/6.2 Entity and numeric character references/CM309/"

  tests/Text/MMark/TestUtils.hs:111:37: 
  2) parse and render, 6.2 Entity and numeric character references, CM310
       expected: "<p><a href=\"/f&amp;ouml;&amp;ouml;\" title=\"föö\">foo</a></p>
"
        but got: "<p><a href=\"/f%26ouml%3b%26ouml%3b\" title=\"föö\">foo</a></p>
"

  To rerun use: --match "/parse and render/6.2 Entity and numeric character references/CM310/"

  tests/Text/MMark/TestUtils.hs:111:37: 
  3) parse and render, 6.5 Links, CM468
       expected: "<p><a href=\"foo(and(bar\">link</a>))</p>
"
        but got: "<p><a href=\"foo%28and%28bar\">link</a>))</p>
"

  To rerun use: --match "/parse and render/6.5 Links/CM468/"

  tests/Text/MMark/TestUtils.hs:111:37: 
  4) parse and render, 6.5 Links, CM470
       expected: "<p><a href=\"foo(and(bar)\">link</a></p>
"
        but got: "<p><a href=\"foo%28and%28bar%29\">link</a></p>
"

  To rerun use: --match "/parse and render/6.5 Links/CM470/"

  tests/Text/MMark/TestUtils.hs:111:37: 
  5) parse and render, 6.5 Links, CM474
       expected: "<p><a href=\"foo%20b&amp;auml;\">link</a></p>
"
        but got: "<p><a href=\"foo%20b%26auml%3b\">link</a></p>
"

  To rerun use: --match "/parse and render/6.5 Links/CM474/"

  tests/Text/MMark/TestUtils.hs:111:37: 
  6) parse and render, 6.7 Autolinks, CM568
       expected: "<p><a href=\"mailto:FOO@BAR.BAZ\">FOO@BAR.BAZ</a></p>
"
        but got: "<p><a href=\"mailto:FOO%40BAR.BAZ\">FOO@BAR.BAZ</a></p>
"

  To rerun use: --match "/parse and render/6.7 Autolinks/CM568/"

  tests/Text/MMark/TestUtils.hs:111:37: 
  7) parse and render, 6.7 Autolinks, CM570
       expected: "<p><a href=\"made-up-scheme://foo/,bar\">made-up-scheme://foo/,bar</a></p>
"
        but got: "<p><a href=\"made-up-scheme://foo/%2cbar\">made-up-scheme://foo/%2cbar</a></p>
"

  To rerun use: --match "/parse and render/6.7 Autolinks/CM570/"

  tests/Text/MMark/TestUtils.hs:111:37: 
  8) parse and render, 6.7 Autolinks, CM575
       expected: "<p><a href=\"mailto:foo@bar.example.com\">foo@bar.example.com</a></p>
"
        but got: "<p><a href=\"mailto:foo%40bar.example.com\">foo@bar.example.com</a></p>
"

  To rerun use: --match "/parse and render/6.7 Autolinks/CM575/"

  tests/Text/MMark/TestUtils.hs:111:37: 
  9) parse and render, 6.7 Autolinks, CM576
       expected: "<p><a href=\"mailto:foo+special@Bar.baz-bar0.com\">foo+special@Bar.baz-bar0.com</a></p>
"
        but got: "<p><a href=\"mailto:foo%2bspecial%40Bar.baz-bar0.com\">foo+special@Bar.baz-bar0.com</a></p>
"

  To rerun use: --match "/parse and render/6.7 Autolinks/CM576/"

Randomized with seed 1531926179

Finished in 0.1728 seconds
614 examples, 9 failures
Test suite tests: FAIL
Test suite logged to: dist/test/mmark-0.0.7.4-tests.log
0 of 1 test suites (0 of 1 test cases) passed.

Here are the full build logs (2 files).

mrkkrp commented 2 years ago

Indeed, this error is even present in the CI runs. I'm going to take a look.

mrkkrp commented 2 years ago

Will release a new version of MMark (0.0.7.5) shortly.