search

mmarkelov / react-nouislider

React wrapper on NoUiSlider
https://mmarkelov.github.io/react-nouislider/
MIT License
60 stars 21 forks source link

Fix error when setting new range and value #11

Closed alexmasnou closed 5 years ago

alexmasnou commented 5 years ago

I have noticed that there is an error when updating the range and the value (combined). The error can be reproduced here: https://codesandbox.io/s/0moo1437m0

For solving this error, the range must be updated before changing the 'start' value.

mmarkelov commented 5 years ago

@alexmasnou good catch! Thank you!

alexmasnou commented 5 years ago

@mmarkelov sorry for bothering you again. I think the last hotfix have an issue with generated assets. The last fix is not working (see https://codesandbox.io/s/7mmmx92830) but the changes are present in source code.

mmarkelov commented 5 years ago

@alexmasnou thank you! Find out that there are problems with publishing package. Version 2.3.3 should be fix it, and I'll find solution to fix these problems.

shivamragnar commented 2 years ago

I guess this is not yet fixed, having dynamic values for start prop does not seem to be working. My use case has dynamically switching between a range slider with two handles, and normal slider with one handle. Not sure if this is still a bug in here. @mmarkelov