mmasana / FACIL

Framework for Analysis of Class-Incremental Learning with 12 state-of-the-art methods and 3 baselines.
https://arxiv.org/pdf/2010.15277.pdf
MIT License
512 stars 98 forks source link

Adding a new dataset #29

Closed andreadaou closed 1 year ago

andreadaou commented 1 year ago

Hi !

As mentioned in README.md to add a custom dataset:

If I follow the steps mentioned above to add newdataset, I will get: FACIL dataset_config_newdataset data_loader_newdataset

Till now, is this correct?

In the newdataset folder added in data folder shown in FACIL capture, should I insert all the train and test images as .jpg files? In addition to train.txt and test.txt ?

Sorry for this long question but I'm having a problem when adding a custom dataset. Appreciate your help !! Thank you :)

mmasana commented 1 year ago

If you are using our system of train.txt and test.txt files. Then you do not need lines 136 and 137 (from the third image you posted). It should work directly with the part from 139-145. With the else-branch you have created the dataset is probably empty, and that's why it would not be working.

The .txt. files will contain as the first column the path to the images, so it doesn't matter where the images are stored as long as the paths are correct. I would recommend using absolute paths.

The dataset_config looks correct.

Usually, the data folder is created inside the FACIL folder, same "height" in the tree as src or scripts. So that could be an issue too?

Feel free to post the errors you get so I know where they might be coming from.

andreadaou commented 1 year ago

Thank you so much @mmasana !! I believe the code is now operating correctly.

I will post the new errors if any occur (hopefully none will). Thank you again !