search

mmasana / FACIL

Framework for Analysis of Class-Incremental Learning with 12 state-of-the-art methods and 3 baselines.
https://arxiv.org/pdf/2010.15277.pdf
MIT License
512 stars 98 forks source link

gridsearch-tasks == -1 in args does not perform grid search #7

Open ashok-arjun opened 2 years ago

ashok-arjun commented 2 years ago

Hello!

Thank you very much for this library - it's great!

I have a question:

The default value of --gridsearch-tasks in main_incremental.py is -1. And it has been given that setting it to -1 will perform grid search for all tasks.

But this does not reflect in the code, and grid search is not done when this is executed.

The only lines where gridsearch_tasks is referenced are line 167, line 214 and line 241 and all of these work only when the value is positive.

Can you please check if the code is right?

Thank you.

mkmenta commented 2 years ago

Hi, thanks for the issue!

I think you are right! I will check it out.

Thank you so much!

_(Noting, just in case: setting it to the value of --num-tasks as done here should run the full GridSearch)._

ashok-arjun commented 2 years ago

Thank you @mkmenta. Got it, will use --num-tasks.