search

mmastrac / rust-ctor

Module initialization/global constructor functions for Rust
Apache License 2.0
739 stars 49 forks source link

chore: Upgrade to syn 2.0 #262

Closed audunhalland closed 1 year ago

mmastrac commented 1 year ago

Thank you, I'll push a new version with a minor bump.

Kixunil commented 1 year ago

Hey, from my understanding, this didn't change the API so bumping minor version wasn't really needed. Not a big deal I guess just something to be aware of in the future. Cool crate, BTW!

mmastrac commented 1 year ago

Technically true from a strict semver read, but it makes it slightly easier for people to select which version they want based on the minor since it's still a 0.x project as some folks prefer not to have two major version lines of syn in their trees.

Kixunil commented 1 year ago

That's still possible using Cargo.lock and that's what should be used (and I use it). Doing it via Cargo.toml makes the experience strictly worse because e.g. some other crate might forget to use ranged version and then it forces specific version on people.

mmastrac commented 1 year ago

In this case it doesn't hurt anything to also bump the minor because it's still 0.x, but thanks for your feedback.