search

mmatl / pyrender

Easy-to-use glTF 2.0-compliant OpenGL renderer for visualization of 3D scenes.
http://pyrender.readthedocs.io/
MIT License
1.31k stars 225 forks source link

PyOpenGL dependency version #224

Open cosw0t opened 2 years ago

cosw0t commented 2 years ago

Hi! is there any reason why there is a hard dependency on pyopengl==3.1.0?

pyopengl is now at version 3.1.6, with lots of bug fixes and no API changes. Would it make sense to remove the hard version requirement?

thanks!

cwiede commented 2 years ago

+1 just stumbled upon the same step stone

mmatl commented 2 years ago

Add a PR to correct the hard dep and I'll patch!

cosw0t commented 2 years ago

Thanks @mmatl, the PR is here! #226

I have just noticed that master already has a commit that gets around the issue with a "PyOpengl~=3.1.0". I hadn't noticed it because it's not in pip yet. I guess it's up to you to chose which on you prefer now :) fell free to close my PR if you wish.

cwiede commented 2 years ago

Oh just started to do it, but then I realized that the patch seems to be already in place: https://github.com/mmatl/pyrender/commit/7c613e8aed7142df9ff40767a8f10b7a19b6255c. I'd have used a ">=3.1.0,<4.0.0" instead of the "~=3.1.0" dependency, but anyways the existing patch patch seems to correct the issue.

However, the last release on pypi doesn't incorporate it.

@michele-arrival you have overtaken my response :)

cosw0t commented 2 years ago

you have a point though, ~=3.1.0 will not update to 3.2.x, whereas ">=3.1.0,<4.0.0" will. I'm not sure what's best. again i 'm happy to leave that decision to matt

nlsdvl commented 2 years ago

+1 running into this as well. Anyways ... great job on this library.

orperel commented 1 year ago

Hi! Any news for bumping the PyOpenGL's min version for the wheels? I'd love to test this with kaolin-wisp, but the downgraded gl version requires us to turn off features like anisotropic filtering.

Love the lightweight design btw, kudos on a great library!

MaxGyver83 commented 1 year ago

I ran into this as well. A new tag/release would be nice!

traversaro commented 5 months ago

Just in case somebody stumbles in this issue, we had the same problem for urdfpy : https://github.com/mmatl/urdfpy/issues/31 . As urdfpy depends on pyrender, for our friendly fork we also friendly forked pyrender in https://github.com/fishbotics/pyribbit . pyribbit is just pyrender renamed (to avoid any naming clash) and with the pyopengl pinning resolved, and available on both pip (pypi) and conda-forge.