search

mmatl / pyrender

Easy-to-use glTF 2.0-compliant OpenGL renderer for visualization of 3D scenes.
http://pyrender.readthedocs.io/
MIT License
1.27k stars 222 forks source link

fx and fy in IntrinsicsCamera are in pixel units? #50

Open snavely opened 5 years ago

snavely commented 5 years ago

The documentation of IntrinsicsCamera states that the fx and fy input parameters are in units of meters. However, it is difficult for me to understand what that means, since to understand focal length in meter units means that you also know the size of the sensor (or image plane) in meters as well... instead, it seems from my tests that fx and fy are actually meant to be specified in pixel units. Is that correct?

mmatl commented 5 years ago

Yes, that's correct! I'll update the docs soon.

duanyongli commented 4 years ago

@mmatl Thanks for your great work, and fx and fy input parameters are still in units of meters.

johnwlambert commented 3 years ago

Hi @mmatl, thanks for the great library.

It looks like @snavely's PR fixed the docstring but the docs still need to be updated or regenerated -- https://pyrender.readthedocs.io/en/latest/generated/pyrender.camera.IntrinsicsCamera.html