search

mmatvein / libliquidfun-sys

A thin Rust ffi wrapper on top of Box2D and LiquidFun.
Apache License 2.0
2 stars 2 forks source link

Mouse joint #2

Open amytimed opened 9 months ago

amytimed commented 9 months ago

Mouse joint bindings :+1:

mmatvein commented 9 months ago

Hey! Thanks for the PR. I think the mouse joint part is obviously mergeable, but I'm hesitant to change the box2d defaults through this crate, especially as the max translation you're proposing is so much bigger than the box2d default. Please push the branch without that commit and I'll merge the mouse joint change.

amytimed commented 9 months ago

alright ill remove that

it was added by accident since i did PR change on main but then did other fork changes on main after, but it was tested in the past and Box2D has no issues with limits that far, i would say its less accurate with limit since objects suddenly ceasing acceleration is unrealistic

will fix though

amytimed commented 9 months ago

fixed, rewinded reality