search

mmatyas / pegasus-frontend

A cross platform, customizable graphical frontend for launching emulators and managing your game collection.
http://pegasus-frontend.org
Other
1.22k stars 111 forks source link

Fix QLatin1String error for flatpak #1006

Closed j8r closed 2 years ago

j8r commented 2 years ago

Flatpak builds were failing for several months, unfortunately I'm not notified for CI errors in master - only for PRs. I'm looking for a solution.

The error here is:

/run/build/pegasus-frontend/src/backend/ProcessLauncher.cpp: In member function ‘void ProcessLauncher::onLaunchRequested(const model::GameFile*)’:
/run/build/pegasus-frontend/src/backend/ProcessLauncher.cpp:168:48: error: no match for ‘operator%’ (operand types are ‘QLatin1String’ and ‘const QString’)
  168 |         QLatin1String("flatpak-spawn --host ") % game.launchCmd();
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~
      |         |                                                      |
      |         QLatin1String                                          const QString

Replacing the % by a + makes the flatpak build. Launching flatpaks inside Pegasus works,

mmatyas commented 2 years ago

Thanks! I don't think I was notified about the build errors either.