Changed Lutris asset folder to .cache

mmatyas / pegasus-frontend

A cross platform, customizable graphical frontend for launching emulators and managing your game collection.

http://pegasus-frontend.org

Other

1.25k stars 112 forks source link

Closed CosmicEventHorizon closed 11 months ago

CosmicEventHorizon commented 1 year ago

Fixed Issue #1073. I added a function to look in the cache folder for lutris assets and to use them. Tested it and it seems to be working now

Disclaimer: This is my first PR and my knowledge on CPP is limited so please merge only if appropriate :+1: Thanks :)

mmatyas commented 1 year ago

Thanks for the fix! It might be that something changed in Lutris, so I'd like to take a look in the source code first sometime.

mmatyas commented 12 months ago

Really sorry this took so long, I've commented in the issue report.

mmatyas commented 11 months ago

Ok, looks good! Now a little cleanup for the end:

There are 4 separate commits on your branch: Ideally work-in-progress commits are joined into one commit once everything is done. Would you like to squash your commits into one? I can do this too for you, if you don't feel that confident with Git yet.
Code style: There are 2 empty lines at lines 126–127, could you remove one of them? In most part of Pegasus, only one empty line is used inside functions.

CosmicEventHorizon commented 11 months ago

@mmatyas Thanks, I removed the extra empty line and squashed the commits into one