mmatyas / pegasus-frontend

A cross platform, customizable graphical frontend for launching emulators and managing your game collection.
http://pegasus-frontend.org
Other
1.19k stars 106 forks source link

Duplicate steam games #909

Closed zany130 closed 2 years ago

zany130 commented 2 years ago

Hi, and thanks for reporting errors! You can help us locating the bug even more by providing detailed information in the sections below:

The issue

Ever Since lutris 5.9 steam games get added to buth the lutris and steam section of Pegasus ( lutris now add installed steam games to its libary)

System info

╰─λ inxi -Faz System: Kernel: 5.14.11-206-tkg-pds x86_64 bits: 64 compiler: gcc v: 11.1.0 parameters: intel_pstate=passive BOOT_IMAGE=/@/boot/vmlinuz-linux-tkg-pds-generic_v3 root=UUID=ef15347e-a4da-4628-afc3-2bff20cbb710 rw rootflags=subvol=@ quiet nvidia-drm.modeset=1 splash rd.udev.log_priority=3 vt.global_cursor_default=0 systemd.unified_cgroup_hierarchy=1 resume=UUID=e7745511-30a0-4b3d-93c1-4bc3daa8b2b8 loglevel=3 sysrq_always_enabled=1 nowatchdog Desktop: KDE Plasma 5.22.5 tk: Qt 5.15.2 info: latte-dock wm: kwin_x11 vt: 1 dm: SDDM Distro: Garuda Linux base: Arch Linux

Pegasus version

alpha15.r85.gfff1a5b2-1

Pegasus log

lastrun.log

You can find a log file with detailed information about the launch of Pegasus under the following locations:

If possible, please attach the file to this bug report.

mmatyas commented 2 years ago

I've tried to reproduce this, but apparently Lutris only works with public Steam profiles, which I'm not planning to do. I'll try to do this in blind.

mmatyas commented 2 years ago

Hm so what happens if you have a game from multiple sources? How do you decide which version you want to launch? By the game's runner setting?

zany130 commented 2 years ago

what do you mean?

mmatyas commented 2 years ago

For example, Battle for Wesnoth is available on Steam, on GOG and also natively by Lutris. If you have it installed from multiple sources, how do you tell Lutris to launch its Steam version?

zany130 commented 2 years ago

when you install the game in lutris you can select what version you want to install and it will install that version and if you want to use another version say the gog version you would have to delete it and reinstall. if its already installed (say by steam) it will just use that you can't have the same game from two sources installed on lutris

mmatyas commented 2 years ago

I see; so if you open a Steam game's Configure page, what do you see on the Runner field?

I'm thinking about this screen:

image

zany130 commented 2 years ago

oh yeah there a seperate runner for using either linux native, steam linux, steam wine (which will install the steam windows client in wine and use that to install/manage the game), or wine. a steam game you cant change though i think really as that's just really a shortcut to steam with the appid afaik it doesn't actually install the game or do anything really

mmatyas commented 2 years ago

Could you post a screenshot of this screen for a Steam game? Pegasus has to decide by something whether the game was installed through Steam or by other means, so I wonder if the Runner field is the one that tells it.

zany130 commented 2 years ago

yeah here is the game info screen for batman Arkham knight for example configured to use the linux steam client image

here the game options image

runner options EDIT: copied the game options screenshot twice image

and then the system options is the same for everything

EDIT2: also you can filter your games in lutris by selecting the runners, source or platform tab on the left of the main window image

Currently, the sources tab will show duplicated information so the issue might be there and not on pegasus

so for example batman shows up on the lutris source and the steam source

the runner and platform filters do not however show duplicated info as a game can be configured with only one platform or runner though those only show installed and configured games

mmatyas commented 2 years ago

Ok, this should be fixed in the latest version, give it a try!

zany130 commented 2 years ago

This seems to hid non steam lutris games for me. For example I have trails to azure which is just a wine game I set up that isn't from any store (bought it directly from the japanese publisher)

mmatyas commented 2 years ago

Hm you mean in the latest version certain games that were visible before, now no longer appear?

zany130 commented 2 years ago

Yeah the example i gave of trails to azure was showing before and now it's not showing

mmatyas commented 2 years ago

Do you see any Lutris related errors in the log? Games should only disappear if the database does not have the expected structure.

mmatyas commented 2 years ago

Nevermind, there's one additional step missing in the code.

mmatyas commented 2 years ago

Ok, Steam games autodetected by Lutris should now appear in the Steam category now.

zany130 commented 2 years ago

yeah still not showing seems like its having trouble reading my lutris library

2022-04-11T14:17:40 [i] Pegasus alpha16-13-ge6500e00 (2022-04-10)
2022-04-11T14:17:40 [i] Running on Garuda Linux (x86_64, xcb)
2022-04-11T14:17:40 [i] Qt version 5.15.3
2022-04-11T14:17:40 [i] Program settings loaded (`/home/zany130/.config/pegasus-frontend/settings.txt`)
2022-04-11T14:17:40 [i] Found locale `ar`
2022-04-11T14:17:40 [i] Found locale `bs`
2022-04-11T14:17:40 [i] Found locale `de`
2022-04-11T14:17:40 [i] Found locale `en-GB`
2022-04-11T14:17:40 [i] Found locale `en`
2022-04-11T14:17:40 [i] Found locale `es`
2022-04-11T14:17:40 [i] Found locale `fr`
2022-04-11T14:17:40 [i] Found locale `hu`
2022-04-11T14:17:40 [i] Found locale `ja`
2022-04-11T14:17:40 [i] Found locale `ko`
2022-04-11T14:17:40 [i] Found locale `lt`
2022-04-11T14:17:40 [i] Found locale `nl`
2022-04-11T14:17:40 [i] Found locale `pt-BR`
2022-04-11T14:17:40 [i] Found locale `ru`
2022-04-11T14:17:40 [i] Found locale `zh-TW`
2022-04-11T14:17:40 [i] Found locale `zh`
2022-04-11T14:17:40 [i] Locale set to `en`
2022-04-11T14:17:40 [i] Found theme `Pegasus Grid` at `:/themes/pegasus-theme-grid/`
2022-04-11T14:17:40 [i] Found theme `bartopOS` at `/home/zany130/.config/pegasus-frontend/themes/bartopOS-master/`
2022-04-11T14:17:40 [i] Found theme `clearOS` at `/home/zany130/.config/pegasus-frontend/themes/clearOS-main/`
2022-04-11T14:17:40 [i] Found theme `gameOS - Fire` at `/home/zany130/.config/pegasus-frontend/themes/gameOS-master/`
2022-04-11T14:17:40 [i] Found theme `Homage` at `/home/zany130/.config/pegasus-frontend/themes/pegasus-theme-homage-master/`
2022-04-11T14:17:40 [i] Found theme `RefiOS` at `/home/zany130/.config/pegasus-frontend/themes/pegasus-theme-refiOS-master/`
2022-04-11T14:17:40 [i] Found theme `prosperoOS` at `/home/zany130/.config/pegasus-frontend/themes/prosperoOS-master/`
2022-04-11T14:17:40 [i] Found theme `shinretro` at `/home/zany130/.config/pegasus-frontend/themes/shinretro-master/`
2022-04-11T14:17:40 [i] Found theme `skylineOS` at `/home/zany130/.config/pegasus-frontend/themes/skylineOS-master/`
2022-04-11T14:17:40 [i] SDL version 2.0.20
2022-04-11T14:17:41 [i] Theme set to `clearOS` (`/home/zany130/.config/pegasus-frontend/themes/clearOS-main/`)
2022-04-11T14:17:41 [i] Icon theme "adwaita" not found.
2022-04-11T14:17:41 [i] Icon theme "ubuntu-mono" not found.
2022-04-11T14:17:41 [i] Icon theme "yaru" not found.
2022-04-11T14:17:41 [i] Icon theme "Mint-X" not found.
2022-04-11T14:17:41 [i] Icon theme "elementary" not found.
2022-04-11T14:17:41 [i] Gamepad: Connected device 0x0 (py-evdev-uinput)
2022-04-11T14:17:41 [i] Metafiles: No metadata files found
2022-04-11T14:17:41 [i] Metafiles: Finished searching in 0ms
2022-04-11T14:17:41 [i] Media: Finished searching in 0ms
2022-04-11T14:17:41 [i] Steam: Found installation at `/home/zany130/.local/share/Steam/`
2022-04-11T14:17:41 [i] Steam: Found `/home/zany130/.local/share/Steam/config/config.vdf`
2022-04-11T14:17:41 [i] Steam: Found `/home/zany130/.local/share/Steam/steamapps/libraryfolders.vdf`
2022-04-11T14:17:41 [i] Steam: 63 games found
2022-04-11T14:17:41 [i] Steam: Finished searching in 168ms
2022-04-11T14:17:41 [i] GOG: 0 games found
2022-04-11T14:17:41 [i] GOG: Finished searching in 0ms
2022-04-11T14:17:41 [i] EmulationStation: No installation found
2022-04-11T14:17:41 [i] EmulationStation: Finished searching in 0ms
2022-04-11T14:17:41 [i] Logiqx: Finished searching in 0ms
2022-04-11T14:17:41 [i] Lutris: Found data directory: `/home/zany130/.local/share/lutris/`
2022-04-11T14:17:41 [w] Lutris: No query Unable to fetch row
2022-04-11T14:17:41 [i] Lutris: Finished searching in 5ms
2022-04-11T14:17:41 [i] Skraper Assets: 0 assets found
2022-04-11T14:17:41 [i] Skraper Assets: Finished searching in 0ms
2022-04-11T14:17:41 [i] Favorites: Finished searching in 0ms
2022-04-11T14:17:41 [i] Playtime: Finished searching in 0ms
2022-04-11T14:17:41 [i] Waiting for online sources...
2022-04-11T14:17:41 [i] Waiting for online sources took 364ms
2022-04-11T14:17:41 [w] The collection 'GOG' has no valid games, ignored
2022-04-11T14:17:41 [i] Game list post-processing took 0ms
2022-04-11T14:17:41 [i] 63 games found
2022-04-11T14:17:41 [w] file:///home/zany130/.config/pegasus-frontend/themes/clearOS-main/theme.qml:7:1: QML FocusScope: Binding loop detected for property "darkMode"
2022-04-11T14:17:41 [w] file:///home/zany130/.config/pegasus-frontend/themes/clearOS-main/theme.qml:7:1: QML FocusScope: Binding loop detected for property "darkMode"
2022-04-11T14:17:41 [w] DelegateModel::cancel: index out range 0 0
2022-04-11T14:17:41 [w] file:///home/zany130/.config/pegasus-frontend/themes/clearOS-main/GridItem.qml:173: TypeError: Property 'logo' of object [null] is not a function
2022-04-11T14:17:41 [w] file:///home/zany130/.config/pegasus-frontend/themes/clearOS-main/GridItem.qml:173: TypeError: Property 'logo' of object [null] is not a function
2022-04-11T14:17:41 [w] file:///home/zany130/.config/pegasus-frontend/themes/clearOS-main/GridItem.qml:173: TypeError: Property 'logo' of object [null] is not a function
2022-04-11T14:17:41 [w] file:///home/zany130/.config/pegasus-frontend/themes/clearOS-main/CollectionView.qml:280: TypeError: Cannot read property 'right' of null
2022-04-11T14:17:41 [w] file:///home/zany130/.config/pegasus-frontend/themes/clearOS-main/CollectionView.qml:280: TypeError: Cannot read property 'left' of null
2022-04-11T14:17:51 [w] qt.qpa.xcb: QXcbConnection: XCB error: 148 (Unknown), sequence: 496, resource id: 0, major code: 140 (Unknown), minor code: 20
2022-04-11T14:17:52 [w] file:///home/zany130/.config/pegasus-frontend/themes/clearOS-main/GridItem.qml:173: TypeError: Property 'logo' of object [null] is not a function
2022-04-11T14:17:52 [w] file:///home/zany130/.config/pegasus-frontend/themes/clearOS-main/GridItem.qml:173: TypeError: Property 'logo' of object [null] is not a function
2022-04-11T14:18:34 [i] Theme set to `Pegasus Grid` (`:/themes/pegasus-theme-grid/`)
2022-04-11T14:18:34 [i] Program settings saved
2022-04-11T14:18:34 [w] Warning: "Internal data flow problem."
2022-04-11T14:18:43 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:44 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:44 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:44 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:44 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:47 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:47 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:47 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:47 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:48 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:48 [w] libpng warning: iCCP: known incorrect sRGB profile
2022-04-11T14:18:50 [i] Executing command: [`steam`,`steam://rungameid/734880`]
2022-04-11T14:18:50 [i] Working directory: `/home/zany130`
2022-04-11T14:18:50 [i] Process 102336 started
2022-04-11T14:18:50 [i] ----------------------------------------
2022-04-11T14:18:51 [i] ----------------------------------------
2022-04-11T14:18:51 [i] The external program has finished cleanly
2022-04-11T14:18:52 [i] Executing command: [`steam`,`steam://rungameid/734880`]
2022-04-11T14:18:52 [i] Working directory: `/home/zany130`
2022-04-11T14:18:52 [i] Process 102525 started
2022-04-11T14:18:52 [i] ----------------------------------------
2022-04-11T14:18:53 [i] ----------------------------------------
2022-04-11T14:18:53 [i] The external program has finished cleanly
2022-04-11T14:18:58 [w] Warning: "Internal data flow problem."
2022-04-11T14:19:00 [w] Warning: "Internal data flow problem."

Lutris: No query Unable to fetch row

mmatyas commented 2 years ago

Hm looks like your Lutris files might be different that mine; if you can post a zip of your Lutris files (~/.local/share/lutris/) I can look into it. I don't know if the files contain sensitive info though (they don't in mine), but you can find me on Discord too if you prefer that.

zany130 commented 2 years ago

ok dm you on discord

mmatyas commented 2 years ago

There were indeed some differences, but this should be working now in the latest version. Thanks for the help!

zany130 commented 2 years ago

Yup. Works. Thanks!!