Open SupervisedThinking opened 3 years ago
mmatyas
commented
3 years ago Yeah, CMake for the Pi 4 is not too well tested yet. In this case, private/qeglfsintegration_p.h is a Qt internal header, so you might need to explicitly tell its path to the compiler. You'll also need to link to some of the internal Qt libraries, like the QMake part of the Pi 4 patch does, though CMake might handle this for you.
SupervisedThinking
commented
3 years ago Well normally CMake should use the cmake conf files similiar to pkgconfig & pick up the headers needed for includes? Beside that your "RPi" patch isn't exactly a patch limited to the RPi 😃 I use (need) it for Rockchip & Amlogic devices too which use GBM/EGLFS + Qt so fixing this / adding this to your CMake build would help to use your frontend on plenty of boards.
I've google a bit & checked my toolchain has a file in (...)/sysroot/usr/lib/cmake/Qt5EglFSDeviceIntegration/Qt5EglFSDeviceIntegrationConfig.cmake & this one contains the include paths to private/qeglfsintegration_p.h or to be precise to the top dir of the headers. But fixing CMake is way out of my skills 🙈
The issue
To fix https://github.com/mmatyas/pegasus-frontend/issues/800 I still need this patch https://github.com/mmatyas/pegasus-frontend/issues/800#issuecomment-782184324 but although https://github.com/mmatyas/pegasus-frontend/commit/fff1a5b2390aaa195d644b651e54c27c2a9b8a1d builds fine when I switch to CMake the EGLFS bug occurs & I when I apply the patch the build fails, when I use make/qmake it builds & works fine.
Build log:
System info
History of packages:
https://github.com/SupervisedThinking/LibreELEC-RR/commits/master-rr/packages/supervisedthinking/emulation/frontends/Pegasus-Frontend/pegasus-frontend/package.mk
Pegasus version
https://github.com/mmatyas/pegasus-frontend/releases/tag/continuous