search

mmatyas / pegasus-theme-es2-simple

2 stars 3 forks source link

Missing scrap image moves the gameLabels left #3

Closed substring closed 5 years ago

substring commented 5 years ago

Hi!

First of all: congratulations for all that work you've done so far with Pegasus. It looks veeeery promising, and I hope i'll be able to contribute further (I'm struggling really much with the theme tutorial, trying to match it up to the new API :sweat_smile: )

Regarding the theme: when the the boxart image is missing, the size is not "reserved", so the gameLabels are moved to the left. This is not comfortable for the eyes, and not like how ES renders it. Even if the box art is missing, it should be 256 pixels wide.

mmatyas commented 5 years ago

Ok, I've set a minimum and maximum width for the image, should be fine now.

Yeah there have been a few breaking changes lately with the themes and all, but as soon as I'm done with them I plan to update the docs. Sorry for the inconvenience!

substring commented 5 years ago

Don't be sorry, that was a great opportunity to dig further with QML and pegasus internals ! Anyway, the quality of the documentation is great already, just the api which is now really outdated.