mmazi / rescu

A lightweight json Rest client utility for JAX-RS
MIT License
65 stars 60 forks source link

debug logging of request/response #117

Closed PavelNiedoba closed 4 years ago

PavelNiedoba commented 6 years ago

Modified logging so better fit production by adding DEBUG, which logs responses truncated at some maximum length so it don't bloat the logs

mmazi commented 6 years ago

Nice, thanks!

I'll merge this immediately when fixes are done.

PavelNiedoba commented 6 years ago

I'm not sure abut what fixes you talking about ? Shall I fix something ?

mmazi commented 6 years ago

I wrote some comments on the code on the GitHub Pull Request page. I suggested small improvements, please review. Thanks!

PavelNiedoba commented 4 years ago

can't see any comments, feel free to make changes

mmazi commented 4 years ago

I'm not sure why you can't see my suggestions. They are not visible if you are not logged in, but you must have been logged in to make the above comment. They are visible to me here and also on this discussion page. Attaching a screenshot.

Screenshot 2020-05-19 at 07 38 27
PavelNiedoba commented 4 years ago

I dont know why your comments are not showing to me. It should be enabled

image

but theres nothing i can see in the code

image

I did your sugestions according the screenshot

mmazi commented 4 years ago

Javadocs for responseMaxLogLen and requestMaxLogLen still seem to be incorrect (request/response swapped).

PavelNiedoba commented 4 years ago

fixed