search

mmazzarolo / breathly-app

A tiny breath training app built with React-Native
https://breathly.app
Mozilla Public License 2.0
520 stars 69 forks source link

Allow customizing breathing steps up to 99s #102

Closed rootsh0pf closed 1 year ago

rootsh0pf commented 1 year ago

It would be super nice if you could rise or maybe even remove the limit on the "Hold" times under custom pattern. Like this the app would be perfect for advanced freediving breath hold training. I guess raising the limit from 60 to 99 seconds would be easy and already very helpful. For more than 100 seconds an extra digit would be needed, but then it would be perfect ;)

Anyway thank you for this App, it's beautiful and as it is it's already very useful for me!

mmazzarolo commented 1 year ago

Hey there! Holy moly I didn't expect people to hold their breath this much, haha. Yeah, this change should be straightforward up to 99 seconds — I think this could be an easy first step and then we can think how to redesign to UI to handle triple digits. I also guess it would be nice to be able to hold the decrease/increase buttons instead of tapping it so many times, right? :D

rootsh0pf commented 1 year ago

That sounds perfect :) Offtopic: Haha yeah if you do a session of 5-15 minutes every day and increase the hold time by a few seconds each day you can make impressing progress ;)

rootsh0pf commented 1 year ago

I want to try implementing this little change. But beware I've never contributed on Github before xD