search

mmazzarolo / react-native-dialog

Pure JavaScript React-Native dialog
MIT License
681 stars 111 forks source link

verticalButtons prop #110

Closed sidferreira closed 3 years ago

sidferreira commented 3 years ago

Overview

verticalButtons: changes the design so the buttons are vertical instead of horizontal

Related to #47, but I did the change before seeing the issue Replaces #108

iOS default iOS vertical Android default Android vertical
Simulator Screen Shot - iPhone 11 - 2021-07-08 at 10 13 02 Simulator Screen Shot - iPhone 11 - 2021-07-08 at 10 17 15 Screenshot_1625764777 Screenshot_1625764786
mmazzarolo commented 3 years ago

Thanks @sidferreira 👍 Code is looking good, I'll give it a try this weekend and if everything works fine I'll merge it.

mmazzarolo commented 3 years ago

@sidferreira I updated the code to achieve the same result without having to pass down the vertical prop to the modal. Mind checking it?

sidferreira commented 3 years ago

@mmazzarolo my bad, forgot to test. If it works, that's great!

Any idea when you plan to release it?

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 8.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: