search

mmazzarolo / react-native-dialog

Pure JavaScript React-Native dialog
MIT License
681 stars 111 forks source link

fix: Typescript fixes #121

Closed SimpleCreations closed 3 years ago

SimpleCreations commented 3 years ago

Overview

mmazzarolo commented 3 years ago

Thank you @SimpleCreations ! 🧡 I'm taking a look at it, mind fixing the linting error in the meanwhile? (Otherwise, I'll fix it later — not sure why Husky didn't fix it)

SimpleCreations commented 3 years ago

Wondering if this should be a major bump or not. At a first glance, I'm not seeing cases where we're making existing types more strict. But normally, when we do these many type changes in a single shot, I prefer doing major releases to ensure we don't break existing build type-checks.

What do you think?

I don't see a major version bump being necessary because yes, seems like we're only making the types less strict.

However I don't have experience maintaining public npm packages so I'm not sure about the potential pitfalls.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 9.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: