Needs to be upgraded to use deprecated-react-native-prop-types

mmazzarolo / react-native-dialog

Pure JavaScript React-Native dialog

MIT License

682 stars 111 forks source link

Needs to be upgraded to use deprecated-react-native-prop-types #146

Closed Nantris closed 2 years ago

Nantris commented 2 years ago

0.69 breaks this library.

PS @mmazzarolo I didn't forget about the other incomplete PRs I still owe you!

Nantris commented 2 years ago

Listing specific changes needed:

Import ViewPropTypes deprecated-react-native-prop-types instead of react-native
style: (Text as any).propTypes.style - Unknown how to update this properly

I should be able to make these changes when I complete my pending PRs, but @mmazzarolo do you know the correct solution for the second bullet item? I didn't have much luck finding info on it, but I don't really know about React Native-specific propTypes.

mmazzarolo commented 2 years ago

Hello hello @Slapbox ! I'm also not familiar with any new React-Native-specific prop (nor with newer React-Native versions in general 😓). I'm fine with any approach that solves the current incompatibility, even if it means making the prop typing more flexible — we can then create follow-up GitHub issues about known potential improvements. Thank you!

Nantris commented 2 years ago

Obsolete before I even made the issue! Fixed by #139.