search

mmazzarolo / react-native-dialog

Pure JavaScript React-Native dialog
MIT License
681 stars 111 forks source link

Add unstableLabelStyle & fix switch statement comparison method #150

Closed Nantris closed 1 year ago

Nantris commented 1 year ago

@mmazzarolo sorry for the huge delay - I'm finally getting around to this!

This PR:

  1. Adds unstableLabelStyle (#144)
  2. Changes comparisons on .type to .type?.displayName (#143)
  3. Fixes TypeScript complaints that predate this work (although I later rebased the changes not having realized there was a 9.2.2 release, so maybe irrelevant)

I made the new PR to avoid having to do any force pushes after the rebase.

I've tested this branch in our application and it works as intended in my testing (although, trivial difference, to test it had to change "main": "lib/index.js" "main": "src/index.ts" to work around no postinstall for packages installed from git commits)

Please let me know if you see any remaining issues and I'll get those squared away, but I think there are none.

Sorry again for the delay!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 9.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: